Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Tue, 24 Oct 2017 14:44:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.12538600.1326782030000.45935.1508856240485@Atlassian.JIRA>
In-Reply-To: <JIRA.12538600.1326782030000@Atlassian.JIRA>
References: <JIRA.12538600.1326782030000@Atlassian.JIRA> <JIRA.12538600.1326782030169@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-1363) Categorise unit tests by
 'test-commit', 'full-test' etc
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 24 Oct 2017 14:44:07 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1363?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
16217023#comment-16217023 ]=20

ASF GitHub Bot commented on ZOOKEEPER-1363:
-------------------------------------------

GitHub user mfenes reopened a pull request:

    https://github.com/apache/zookeeper/pull/375

    ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc

    ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc
   =20
    Added new capability of defining test categories in test category confi=
guration files. Test category configuration files can contain list of test =
file names and/or patterns. It is also possible to exclude tests from a tes=
t category. Test categories are added to ${test.src.dir}/category directory=
. Current test categories are defined so that they remained API compatible =
with the previous build.xml in regards to how =E2=80=98ant test=E2=80=99 sh=
ould be run (options are the same and they behave the same way).=20
    Func and Perf categories are added to keep the previous FuncTest and Pe=
rfTest categories which were coded into the test file names.
    Slow test category is added and contains tests which require more than =
30 seconds to complete on a local developer machine.
    Command =E2=80=98ant test -Dtest.quick=3Dyes=E2=80=99 runs tests minus =
tests in the Slow category.
    Command =E2=80=98ant test -Dtest.category=3D<category name>=E2=80=99 ru=
ns tests from the specified category.
    It is possible to combine these two options to run a test category minu=
s the Slow tests.
   =20
    Test category file name must match the name of the test category (e.g. =
category/Commit).
    List of excluded tests/patterns should be added to a .exclude file havi=
ng the same name as the category (e.g. category/Commit.exclude).
   =20
    Added README.txt which describes how to run unit tests in detail.
   =20
    Benefits:
     - test categories do not need to be included in the test file names (a=
 test can be part of more than just one category).
     - Slow test category is more flexible to exclude slow tests than the h=
ardcoded exclusion of =E2=80=9C**/*HammerTest.java=E2=80=9D in build.xml.
     - new test categorization can also exclude test file names/patterns fr=
om a category.
     - test category can be added for a patch.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mfenes/zookeeper ZOOKEEPER-1363

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/375.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #375
   =20
----
commit cd51fe57cd839f49bf7babdae4ebded3c92f4b26
Author: Mark Fenes <mfenes@cloudera.com>
Date:   2017-09-08T15:00:29Z

    ZOOKEEPER-1363: Categorise unit tests by 'test-commit', 'full-test' etc

commit 30414528e8550fa4835beb7f8d901f8cad773d6e
Author: Mark Fenes <mfenes@cloudera.com>
Date:   2017-10-24T14:37:29Z

    Trigger notification
   =20
    Change-Id: I38ad5771552ff2bad16271dfb05fa00a683c3228

----


> Categorise unit tests by 'test-commit', 'full-test' etc
> -------------------------------------------------------
>
>                 Key: ZOOKEEPER-1363
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1363
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build, tests
>            Reporter: Henry Robinson
>            Assignee: Mark Fenes
>              Labels: newbie
>
> As discussed on the list, it would be good to split the Java test suite i=
nto categories so that it's easy to run a small set of unit tests against a=
 patch, and to leave Jenkins to run the full suite of stress tests etc.=20


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)