Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: afine <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-409-zookeeper@git.apache.org>
In-Reply-To: <git-pr-409-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTe...
Content-Type: text/plain
Message-Id: <20171027195202.71AD2DFA0A@git1-us-west.apache.org>
Date: Fri, 27 Oct 2017 19:52:02 +0000 (UTC)
archived-at: Fri, 27 Oct 2017 19:52:04 -0000

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/409#discussion_r147500264
  
    --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogNoServerTest.java ---
    @@ -0,0 +1,175 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.test;
    +
    +import org.apache.jute.BinaryInputArchive;
    +import org.apache.jute.BinaryOutputArchive;
    +import org.apache.jute.Record;
    +import org.apache.zookeeper.ZKTestCase;
    +import org.apache.zookeeper.ZooDefs.OpCode;
    +import org.apache.zookeeper.common.Time;
    +import org.apache.zookeeper.server.DataNode;
    +import org.apache.zookeeper.server.DataTree;
    +import org.apache.zookeeper.server.persistence.FileHeader;
    +import org.apache.zookeeper.server.persistence.FileTxnLog;
    +import org.apache.zookeeper.server.persistence.FileTxnSnapLog;
    +import org.apache.zookeeper.txn.*;
    +import org.junit.Assert;
    +import org.junit.Test;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.ByteArrayOutputStream;
    +import java.io.File;
    +import java.io.FileInputStream;
    +import java.nio.ByteBuffer;
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +/**
    + * These tests has been extracted from LoadFromTest, because they don't need test ZK server to run.
    --- End diff --
    
    "have been"


---