Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A2FDD200D26 for ; Fri, 20 Oct 2017 21:50:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A18FA160BCB; Fri, 20 Oct 2017 19:50:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E0BA01609ED for ; Fri, 20 Oct 2017 21:50:28 +0200 (CEST) Received: (qmail 31361 invoked by uid 500); 20 Oct 2017 19:50:27 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 31350 invoked by uid 99); 20 Oct 2017 19:50:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Oct 2017 19:50:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7AA27DF9C5; Fri, 20 Oct 2017 19:50:27 +0000 (UTC) From: afine To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #402: ZOOKEEPER-2922: Flaky Test fix: org.apache.zookeeper.t... Content-Type: text/plain Message-Id: <20171020195027.7AA27DF9C5@git1-us-west.apache.org> Date: Fri, 20 Oct 2017 19:50:27 +0000 (UTC) archived-at: Fri, 20 Oct 2017 19:50:29 -0000 Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/402 I think there is a better way to do this. Picking a new port for each test seems to be a workaround for failing to clean up the resources utilized by a failing test. It would be better if we cleaned up properly after a test execution. Since this is the method we used to fix the test in another branch I think it is up to the discretion of the committers, but it would be nice to not leak any resources from our tests. ---