Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CCEB9200D2A for ; Sat, 14 Oct 2017 01:40:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CB4E7160BE5; Fri, 13 Oct 2017 23:40:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 114D81609E9 for ; Sat, 14 Oct 2017 01:40:24 +0200 (CEST) Received: (qmail 60000 invoked by uid 500); 13 Oct 2017 23:40:24 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 59989 invoked by uid 99); 13 Oct 2017 23:40:23 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Oct 2017 23:40:23 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id AC549DF9FD; Fri, 13 Oct 2017 23:40:23 +0000 (UTC) From: phunt To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #395: ZOOKEEPER-2630: Use interface type instead of implemen... Content-Type: text/plain Message-Id: <20171013234023.AC549DF9FD@git1-us-west.apache.org> Date: Fri, 13 Oct 2017 23:40:23 +0000 (UTC) archived-at: Fri, 13 Oct 2017 23:40:26 -0000 Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/395 @tamaashu your most recent comment highlights another reason why we don't typically encourage wide sweeping refactorings like this - it has the tendency to disrupt patches in flight. It's one of the reasons I've been hesitant to pull it in. ---