zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiafu Jiang (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ZOOKEEPER-2923) The comment of the variable matchSyncs in class CommitProcessor has a mistake.
Date Mon, 23 Oct 2017 02:26:00 GMT
Jiafu Jiang created ZOOKEEPER-2923:
--------------------------------------

             Summary: The comment of the variable matchSyncs in class CommitProcessor has
a mistake.
                 Key: ZOOKEEPER-2923
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2923
             Project: ZooKeeper
          Issue Type: Bug
          Components: quorum
    Affects Versions: 3.5.3, 3.4.10
            Reporter: Jiafu Jiang
            Priority: Minor


The comment of the  variable matchSyncs in class CommitProcessor says:


{code:java}
    /**
     * This flag indicates whether we need to wait for a response to come back from the
     * leader or we just let the sync operation flow through like a read. The flag will
     * be true if the CommitProcessor is in a Leader pipeline.
     */
    boolean matchSyncs;
{code}

I search the source code and find that matchSyncs will be false if  the CommitProcessor is
in a Leader pipeline, and it will be true if the CommitProcessor  is in a Follower pipeline.
Therefore I think the comment should be modified to match the code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message