zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type
Date Fri, 20 Oct 2017 23:39:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213495#comment-16213495
] 

ASF GitHub Bot commented on ZOOKEEPER-2901:
-------------------------------------------

Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/377
  
    Hi @Randgalt - this looks like a reasonable change to me however it's not working. I used
the sample zoo.cfg file as my config and started via bin/zkServer.sh - however I can still
create a ttl based node even though "ttlNodesEnabled=false" in the zoo.cfg. I recommend you
add a test for this.
    
    Can you take a look?
    
    Also I'd appreciate if you could rebase against current apache master. I did this locally
manually, however I'm not sure how the submission script is going to manage it (there were
conflicts because you had merged multiple times, including from third party repos (abe)).
I can probably figure it out, but if you're working to address this issue perhaps you can
fix this too. thx.


> Session ID that is negative causes mis-calculation of Ephemeral Type
> --------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2901
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.3
>         Environment: Running 3.5.3-beta in Docker container
>            Reporter: Mark Johnson
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>
> In the code that determines the EphemeralType it is looking at the owner (which is the
client ID or connection ID):
> EphemeralType.java:
>    public static EphemeralType get(long ephemeralOwner) {
>        if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) {
>            return CONTAINER;
>        }
>        if (ephemeralOwner < 0) {
>            return TTL;
>        }
>        return (ephemeralOwner == 0) ? VOID : NORMAL;
>    }
> However my connection ID is:
> header.getClientId(): -720548323429908480
> This causes the code to think this is a TTL Ephemeral node instead of a
> NORMAL Ephemeral node.
> This also explains why this is random - if my client ID is non-negative
> then the node gets added correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message