zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2727) WARN and stacktrace for normally closed socket
Date Wed, 04 Oct 2017 22:09:01 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192132#comment-16192132
] 

ASF GitHub Bot commented on ZOOKEEPER-2727:
-------------------------------------------

GitHub user mfenes opened a pull request:

    https://github.com/apache/zookeeper/pull/391

    ZOOKEEPER-2727: WARN and stacktrace for normally closed socket

    
    ZOOKEEPER-2727: WARN and stacktrace for normally closed socket
    
    Log level reduced to info for EndOfStreamException as asked in the Jira.
    Logging stack trace for EndOfStreamException has been already moved to debug level in
an earlier commit:
    https://github.com/apache/zookeeper/commit/34665cd5bdbcb6aaeecb6b204028ef1ffab9f2d8
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mfenes/zookeeper ZOOKEEPER-2727

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #391
    
----
commit ab3b6a0de3442fbf782984c0b35de52c76b0974d
Author: Mark Fenes <mfenes@cloudera.com>
Date:   2017-10-04T21:13:26Z

    ZOOKEEPER-2727: WARN and stacktrace for normally closed socket

----


> WARN and stacktrace for normally closed socket
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-2727
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2727
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.9
>            Reporter: Andrey
>            Assignee: Mark Fenes
>
> Steps to reproduce:
> * setup zookeeper
> * setup TCP load balancer. This balancer should check zookeeper clientPort liveness(healthcheck)
by opening and closing TCP connection to clientPort. See https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/
or https://www.digitalocean.com/community/tutorials/how-to-create-your-first-digitalocean-load-balancer#step-2-—-creating-the-load-balancer
for details. 
> * in logs:
> {code}
> 2017-03-17 15:41:19,843 [myid:1] - WARN  [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357]
- caught end of stream exception
> EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely
client has closed socket
> 	at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> 	at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:203)
> 	at java.lang.Thread.run(Thread.java:745)
> {code}
> Issue is here:
> https://github.com/apache/zookeeper/blob/5fe68506f217246c7ebd96803f9c78e13ec2f11a/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java#L322
> -1 is a normal socket termination. 
> Expected:
> * reduce log level to INFO
> * do not log stacktrace.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message