zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2630) Use interface type instead of implementation type when appropriate.
Date Wed, 11 Oct 2017 23:50:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201227#comment-16201227
] 

ASF GitHub Bot commented on ZOOKEEPER-2630:
-------------------------------------------

Github user tamaashu commented on the issue:

    https://github.com/apache/zookeeper/pull/395
  
    The original PR was https://github.com/apache/zookeeper/pull/354, which is already merged
to master. Sadly because of some differences it needed some manual corrections after cherry-picking,
so I had to create this PR separately.
    I've also created https://github.com/apache/zookeeper/pull/399 for branch 3.4, which also
has differences from master.
    
    As far as I know no public interfaces are affected. mhan also reviewed my original changeset.
    Next time I'll create PRs for separate branches in the same time.


> Use interface type instead of implementation type when appropriate.
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2630
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2630
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Michael Han
>            Assignee: Tamas Penzes
>            Priority: Trivial
>              Labels: newbie, refactoring
>             Fix For: 3.6.0
>
>
> There are a couple of places in code base where we declare a field / variable as implementation
type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places
we do the opposite by declaring as interface type. A quick check indicates that most if not
all of these places could be updated so we have a consistent style over the code base (prefer
using interface type), which is also a good coding style to stick per best practice.
> See more info on https://github.com/apache/zookeeper/pull/102



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message