zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2630) Use interface type instead of implementation type when appropriate.
Date Mon, 09 Oct 2017 23:52:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197893#comment-16197893
] 

ASF GitHub Bot commented on ZOOKEEPER-2630:
-------------------------------------------

GitHub user tamaashu opened a pull request:

    https://github.com/apache/zookeeper/pull/399

    ZOOKEEPER-2630: Use interface type instead of implementation type whe…

    Use interface type instead of implementation type when appropriate.
    
    There are a couple of places in code base where we declare a field / variable as implementation
type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places
we do the opposite by declaring as interface type. A quick check indicates that most if not
all of these places could be updated so we have a consistent style over the code base (prefer
using interface type), which is also a good coding style to stick per best practice.
    
    Checked and fixed Set, Map and List interface usages.
    
    Author: Tamas Penzes <tamaas@cloudera.com>
    
    Reviewers: Abe Fine <afine@apache.org>, Michael Han <hanm@apache.org>
    
    Closes #354 from tamaashu/ZOOKEEPER-2630
    
    (cherry picked from commit 1165794be9587acccc02782dbff95bc482222528)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tamaashu/zookeeper ZOOKEEPER-2630-3.4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #399
    
----
commit 3748ed5f8e1023c3e24f598c447de0d9cddd30b2
Author: Tamas Penzes <tamaas@cloudera.com>
Date:   2017-09-11T16:55:05Z

    ZOOKEEPER-2630: Use interface type instead of implementation type whe…
    
    Use interface type instead of implementation type when appropriate.
    
    There are a couple of places in code base where we declare a field / variable as implementation
type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places
we do the opposite by declaring as interface type. A quick check indicates that most if not
all of these places could be updated so we have a consistent style over the code base (prefer
using interface type), which is also a good coding style to stick per best practice.
    
    Checked and fixed Set, Map and List interface usages.
    
    Author: Tamas Penzes <tamaas@cloudera.com>
    
    Reviewers: Abe Fine <afine@apache.org>, Michael Han <hanm@apache.org>
    
    Closes #354 from tamaashu/ZOOKEEPER-2630
    
    (cherry picked from commit 1165794be9587acccc02782dbff95bc482222528)

----


> Use interface type instead of implementation type when appropriate.
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2630
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2630
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Michael Han
>            Assignee: Tamas Penzes
>            Priority: Trivial
>              Labels: newbie, refactoring
>             Fix For: 3.6.0
>
>
> There are a couple of places in code base where we declare a field / variable as implementation
type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places
we do the opposite by declaring as interface type. A quick check indicates that most if not
all of these places could be updated so we have a consistent style over the code base (prefer
using interface type), which is also a good coding style to stick per best practice.
> See more info on https://github.com/apache/zookeeper/pull/102



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message