zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTe...
Date Fri, 27 Oct 2017 19:52:22 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/409#discussion_r147499687
  
    --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ---
    @@ -70,24 +52,37 @@
         private static final int TOTAL_TRANSACTIONS = NUM_MESSAGES + TRANSACTION_OVERHEAD;
         private volatile boolean connected;
     
    -    /**
    -     * test that all transactions from the Log are loaded, and only once
    -     * @throws Exception an exception might be thrown here
    -     */
    -    @Test
    -    public void testLoad() throws Exception {
    +    private ZooKeeper zk;
    +    private ServerCnxnFactory f;
    --- End diff --
    
    i know you didn't pick this variable name but I think it wouldn't be the worst thing to
slip a change to this under the radar.


---

Mime
View raw message