zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTe...
Date Fri, 27 Oct 2017 19:51:57 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/409#discussion_r147499282
  
    --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ---
    @@ -18,49 +18,31 @@
     
     package org.apache.zookeeper.test;
     
    -import java.io.ByteArrayOutputStream;
    -import java.io.File;
    -import java.io.FileInputStream;
    -import java.io.IOException;
    -import java.nio.ByteBuffer;
    -import java.util.ArrayList;
    -import java.util.List;
    -
    -import org.apache.zookeeper.common.Time;
    -import org.apache.jute.BinaryInputArchive;
    -import org.apache.jute.BinaryOutputArchive;
    -import org.apache.jute.Record;
    -import org.apache.zookeeper.CreateMode;
    +import org.apache.zookeeper.*;
    --- End diff --
    
    We generally avoid * imports


---

Mime
View raw message