Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Thu, 28 Sep 2017 07:55:00 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13105678.1506583766000.223379.1506585300493@Atlassian.JIRA>
In-Reply-To: <JIRA.13105678.1506583766000@Atlassian.JIRA>
References: <JIRA.13105678.1506583766000@Atlassian.JIRA> <JIRA.13105678.1506583766573@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2906) The OWASP dependency check jar
 should not be included in the default classpath
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 28 Sep 2017 07:55:06 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183815#comment-16183815 ] 

Hadoop QA commented on ZOOKEEPER-2906:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1052//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1052//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1052//console

This message is automatically generated.

> The OWASP dependency check jar should not be included in the default classpath
> ------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2906
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2906
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.4, 3.6.0, 3.4.11
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>
> The owasp dependency-check-ant jar that we use contains a SLF4J binding that can break logging. We should move it into a separate classpath. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)