Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Thu, 21 Sep 2017 19:48:00 +0000 (UTC)
From: "Jordan Zimmerman (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13103695.1505933656000.169608.1506023280083@Atlassian.JIRA>
In-Reply-To: <JIRA.13103695.1505933656000@Atlassian.JIRA>
References: <JIRA.13103695.1505933656000@Atlassian.JIRA> <JIRA.13103695.1505933656492@jira-lw-us.apache.org>
Subject: [jira] [Issue Comment Deleted] (ZOOKEEPER-2901) Session ID that is
 negative causes mis-calculation of Ephemeral Type
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 21 Sep 2017 19:48:04 -0000


     [ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jordan Zimmerman updated ZOOKEEPER-2901:
----------------------------------------
    Comment: was deleted

(was: The fix for this is straightforward. The hard part is backward compatibility:

* End users have data files with potentially corrupted data
** If they've used a ServerId > 127 with ZK versions 3.5.1+
** If they've used a ServerId > 63 with ZK version 3.5.3
* ContainerManager will treat ephemeral nodes created by servers with the bad Server IDs as container or TTL nodes. 

The fix created here _must_ expire these sessions so that they don't cause problems. The tricky part is how to do this. We need a way to identify old session IDs and new ones. We _could_ bump the {{FileTxnLog.VERSION}} but that would also be tricky to do in a backward compatible way. I'd appreciate ideas here.)

> Session ID that is negative causes mis-calculation of Ephemeral Type
> --------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2901
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.3
>         Environment: Running 3.5.3-beta in Docker container
>            Reporter: Mark Johnson
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>
> In the code that determines the EphemeralType it is looking at the owner (which is the client ID or connection ID):
> EphemeralType.java:
>    public static EphemeralType get(long ephemeralOwner) {
>        if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) {
>            return CONTAINER;
>        }
>        if (ephemeralOwner < 0) {
>            return TTL;
>        }
>        return (ephemeralOwner == 0) ? VOID : NORMAL;
>    }
> However my connection ID is:
> header.getClientId(): -720548323429908480
> This causes the code to think this is a TTL Ephemeral node instead of a
> NORMAL Ephemeral node.
> This also explains why this is random - if my client ID is non-negative
> then the node gets added correctly.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)