Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B0C3E200D04 for ; Mon, 11 Sep 2017 17:18:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AF92D1609C4; Mon, 11 Sep 2017 15:18:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A7D261609C3 for ; Mon, 11 Sep 2017 17:18:14 +0200 (CEST) Received: (qmail 90786 invoked by uid 500); 11 Sep 2017 15:18:13 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 90775 invoked by uid 99); 11 Sep 2017 15:18:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Sep 2017 15:18:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BBDF0183E7E for ; Mon, 11 Sep 2017 15:18:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.952 X-Spam-Level: X-Spam-Status: No, score=-98.952 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id QslEeCqTGiUo for ; Mon, 11 Sep 2017 15:18:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EBF8B60D53 for ; Mon, 11 Sep 2017 15:18:08 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AC9F5E0F12 for ; Mon, 11 Sep 2017 15:18:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C81E124167 for ; Mon, 11 Sep 2017 15:18:02 +0000 (UTC) Date: Mon, 11 Sep 2017 15:18:02 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 11 Sep 2017 15:18:15 -0000 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16161421#comment-16161421 ]=20 ASF GitHub Bot commented on ZOOKEEPER-2814: ------------------------------------------- GitHub user nikhilbhide opened a pull request: https://github.com/apache/zookeeper/pull/369 ZOOKEEPER-2814: Ignore space after comma in connection string Ported ZOOKEEPER-2814 from master to branch 3.4. =20 Added files src/java/main/org/apache/zookeeper/common/StringUtils.java src/java/test/org/apache/zookeeper/test/StringUtilTest.java =20 Modified Files: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/369.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #369 =20 ---- commit 6503f12e144bc6b0652f7adf558bdc28c984e6c0 Author: Flavio Paiva Junqueira Date: 2013-11-15T18:12:07Z ZOOKEEPER-1786. ZooKeeper data model documentation is incorrect (Niraj Tolia via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1542356 13f79535-47bb-0310-9956-ffa450edef68 commit a452d791cff92d65937142c3475a9894264376f6 Author: Flavio Paiva Junqueira Date: 2013-11-16T10:06:19Z ZOOKEEPER-1808. Add version to FLE notifications for 3.4 branch (fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1542489 13f79535-47bb-0310-9956-ffa450edef68 commit b770aeb0c8bcb28a9b653b1dc0edac623c75b509 Author: Flavio Paiva Junqueira Date: 2013-11-17T11:42:22Z ZOOKEEPER-1597. Windows build failing (michim via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1542710 13f79535-47bb-0310-9956-ffa450edef68 commit 7f069c0e084a74f6de661267b828ff3fde30bd11 Author: Flavio Paiva Junqueira Date: 2013-11-23T18:21:38Z ZOOKEEPER-1817. Fix don't care for b3.4 (fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1544858 13f79535-47bb-0310-9956-ffa450edef68 commit c62f2ffa7b9fb026004f66d788ebf1e293d2fdf8 Author: Flavio Paiva Junqueira Date: 2013-11-26T23:43:29Z ZOOKEEPER-1653. zookeeper fails to start because of inconsistent epoch = (michim via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1545883 13f79535-47bb-0310-9956-ffa450edef68 commit 605c8d1b0db0baa57582bb39229c80bfec832ae3 Author: Flavio Paiva Junqueira Date: 2013-11-27T23:23:11Z ZOOKEEPER-1821. very ugly warning when compiling load_gen.c (german bla= nco via fpj) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1546231 13f79535-47bb-0310-9956-ffa450edef68 commit a1cdea63de42ed1eaba224570ad0304c224b21c1 Author: Michi Mutsuzaki Date: 2013-12-04T04:20:53Z ZOOKEEPER-1632. fix memory leaks in cli_st (fpj via michim) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1547703 13f79535-47bb-0310-9956-ffa450edef68 commit f23b85bde1bf53b284a85a8ec6c6251cd63e9feb Author: Flavio Paiva Junqueira Date: 2013-12-07T10:17:54Z ZOOKEEPER-1459. Standalone ZooKeeperServer is not closing=20 the transaction log files on shutdown (Rakesh R via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1548826 13f79535-47bb-0310-9956-ffa450edef68 commit 4822626f958742baf98303fd9cdfcb51ce95cb46 Author: Michi Mutsuzaki Date: 2013-12-10T20:43:22Z ZOOKEEPER-1019. zkfuse doesn't list dependency on boost in README (Raul= Gutierrez Segales via michim) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1549963 13f79535-47bb-0310-9956-ffa450edef68 commit b666d3bccc2e8a0851c4b68024a4c3ac2d97713c Author: Michi Mutsuzaki Date: 2013-12-11T00:12:53Z ZOOKEEPER-1834. Catch IOException in FileTxnLog (fpj via michim) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1550006 13f79535-47bb-0310-9956-ffa450edef68 commit 63b1f92102877757815eec5e0866b7a143868e2d Author: Camille Fournier Date: 2013-12-11T18:31:05Z ZOOKEEPER-1382. Zookeeper server holds onto dead/expired session ids in= the watch data structures (Germ=C3=A1n Blanco and Michael Morello via camille) =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1550220 13f79535-47bb-0310-9956-ffa450edef68 commit fc22886f0c12c0b28780dc29a10c334d1221d9b9 Author: Michi Mutsuzaki Date: 2013-12-14T08:36:46Z ZOOKEEPER-1715. Upgrade netty version (Sean Bridges via michim) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1550902 13f79535-47bb-0310-9956-ffa450edef68 commit ec70dd2c43bc1d780a480487fe4437cb95d01e65 Author: Flavio Paiva Junqueira Date: 2013-12-14T11:23:24Z ZOOKEEPER-1837. Fix JMXEnv checks (potential race conditions) (Germ=C3= =A1n Blanco via fpj) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1550923 13f79535-47bb-0310-9956-ffa450edef68 commit 7e1c76814a267d52c4392c7c181e116b3eb31233 Author: Michi Mutsuzaki Date: 2013-12-16T04:20:40Z ZOOKEEPER-1839. Deadlock in NettyServerCnxn (Rakesh R via michim) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1551112 13f79535-47bb-0310-9956-ffa450edef68 commit a6dec3afdae22bafd8e8fd3c56b258b2a3bbabe8 Author: Patrick D. Hunt Date: 2013-12-16T06:27:56Z ZOOKEEPER-1622. session ids will be negative in the year 2022 (Eric New= ton via phunt) =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1551118 13f79535-47bb-0310-9956-ffa450edef68 commit 5dd0361a5db1e2a5f998344c8abdd0751988eba1 Author: Michi Mutsuzaki Date: 2013-12-16T21:49:50Z ZOOKEEPER-1756. zookeeper_interest() in C client can return a timeval o= f 0 (Eric Lindvall via michim) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1551367 13f79535-47bb-0310-9956-ffa450edef68 commit 6c483a2d67d4aee937e0f4873e4b410b7008e703 Author: Patrick D. Hunt Date: 2013-12-17T16:57:03Z ZOOKEEPER-1388. Client side 'PathValidation' is missing for the multi-t= ransaction api. (Rakesh R via marshallm, phunt) =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1551625 13f79535-47bb-0310-9956-ffa450edef68 commit 54eefdb4fc57e18f28bbb520e4abb163de2f936a Author: Flavio Paiva Junqueira Date: 2013-12-18T13:05:31Z ZOOKEEPER-1841. problem in QuorumTest (Germ=C3=A1n via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1551930 13f79535-47bb-0310-9956-ffa450edef68 commit 5420ead4bb71dfa83f09c4cce72fa72e649eac62 Author: Flavio Paiva Junqueira Date: 2013-12-18T15:48:19Z ZOOKEEPER-1733. FLETest#testLE is flaky on windows boxes=20 (michim via fpj) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1551985 13f79535-47bb-0310-9956-ffa450edef68 commit 058185d6359393e3898acd745f341f1799b276ce Author: Flavio Paiva Junqueira Date: 2013-12-18T15:52:16Z ZOOKEEPER-1733. FLETest#testLE is flaky on windows boxes (michim, Jeffrey Zhong via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1551987 13f79535-47bb-0310-9956-ffa450edef68 commit 7b272f5d5e4d1c170bc72c9b79a462517c06d6d4 Author: Flavio Paiva Junqueira Date: 2013-12-19T22:36:08Z ZOOKEEPER-1849. Need to properly tear down tests in various=20 cases (Germ=C3=A1n via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1552447 13f79535-47bb-0310-9956-ffa450edef68 commit 05bc123a83d0e355f703001c78b3a54988c678e4 Author: Patrick D. Hunt Date: 2013-12-20T01:29:22Z ZOOKEEPER-1430. add maven deploy support to the build (Giridharan Kesav= an via phunt) =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1552470 13f79535-47bb-0310-9956-ffa450edef68 commit 7fc3de3a05c9ace88b0e6b914750b2712f43f7c0 Author: Flavio Paiva Junqueira Date: 2013-12-27T13:29:08Z ZOOKEEPER-1179. NettyServerCnxn does not properly close=20 socket on 4 letter word requests (Rakesh R, Germ=C3=A1n Blanco=20 via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1553672 13f79535-47bb-0310-9956-ffa450edef68 commit 80ef32504a46387e051ca9b58e1b5b58b387b358 Author: Flavio Paiva Junqueira Date: 2013-12-27T16:50:46Z ZOOKEEPER-1179. NettyServerCnxn does not properly close socket on 4 let= ter word requests. (Rakesh R, Germ=C3=A1n Blanco via fpj) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1553694 13f79535-47bb-0310-9956-ffa450edef68 commit 68a0f7315d59f4a8090b3a08bb8dab8453bb2fe9 Author: Flavio Paiva Junqueira Date: 2014-01-03T00:23:23Z ZOOKEEPER-1852. ServerCnxnFactory instance is not properly cleanedup (R= akesh R via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1554979 13f79535-47bb-0310-9956-ffa450edef68 commit 89448077733a8d025734b79346e403cbcdaa9cea Author: Flavio Paiva Junqueira Date: 2014-01-03T00:44:27Z ZOOKEEPER-1852. ServerCnxnFactory instance is not properly cleanedup (R= akesh R via fpj) =20 =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1554983 13f79535-47bb-0310-9956-ffa450edef68 commit ca8d611d2db1234bfc0a3f64f2a2a8a15021c8a3 Author: Michi Mutsuzaki Date: 2014-01-09T19:22:57Z ZOOKEEPER-1414. QuorumPeerMainTest.testQuorum, testBadPackets are faili= ng intermittently (Rakesh R via michim) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1556926 13f79535-47bb-0310-9956-ffa450edef68 commit a6528185040b0f782c3d59650b694cf478e01b6a Author: Michi Mutsuzaki Date: 2014-01-09T21:03:16Z ZOOKEEPER-1057. zookeeper c-client, connection to offline server fails = to successfully fallback to second zk host (Germ=C3=A1n Blanco via michim) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1556949 13f79535-47bb-0310-9956-ffa450edef68 commit 19e4b850e48cbe8f100ab23cada9f2ea0a05d2be Author: Michi Mutsuzaki Date: 2014-01-09T23:01:19Z ZOOKEEPER-1857. PrepRequestProcessotTest doesn't shutdown ZooKeeper ser= ver (Germ=C3=A1n Blanco via michim) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1556977 13f79535-47bb-0310-9956-ffa450edef68 commit 9436a70a24d62d38afea2692d2413bd935981b83 Author: Flavio Paiva Junqueira Date: 2014-01-12T21:36:17Z ZOOKEEPER-1238. when the linger time was changed for NIO the patch miss= ed=20 Netty (Skye Wanderman-Milne via fpj) =20 =20 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-= 3.4@1557614 13f79535-47bb-0310-9956-ffa450edef68 ---- > Ignore space after comma in connection string > --------------------------------------------- > > Key: ZOOKEEPER-2814 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.5.3 > Reporter: Viliam Durina > Assignee: Nikhil Ashok Bhide > Priority: Minor > > I'm using the following connection string: > {{10.0.0.179:2181,10.0.0.176:2181}} > However, I get: > {{java.net.UnknownHostException: 10.0.0.176: Name or service not known > at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method) > at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928) > at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323= ) > at java.net.InetAddress.getAllByName0(InetAddress.java:1276) > at java.net.InetAddress.getAllByName(InetAddress.java:1192) > at java.net.InetAddress.getAllByName(InetAddress.java:1126) > at org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvid= er.java:61) > at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445) > at ... > ...}} > The problem was the space after the comma. I suggest to either make the s= pace optional or produce error on it, as this is a real pain to spot. Using= the space also makes the connect string more readable. Spaces are not allo= wed in domain names. -- This message was sent by Atlassian JIRA (v6.4.14#64029)