Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
MIME-Version: 1.0
In-Reply-To: <CABWqe2asmUcqR6jMxt=Vo=R0LoiLWeDRy=pkjrr0mt_iw1MWkA@mail.gmail.com>
References: <ECB40D61-FE2E-41E1-92ED-4C9042C1B66C@jordanzimmerman.com>
 <774C257B-368C-4AEA-9F88-5E67E8F95055@jordanzimmerman.com>
 <CABWqe2b7QC5ACuJLpHDFxm1rzvZo2TWc_Vb8M=2xCXMzom0GTw@mail.gmail.com>
 <579E917D-E9C7-4089-BF7C-E46C6D1906C0@jordanzimmerman.com> <CABWqe2asmUcqR6jMxt=Vo=R0LoiLWeDRy=pkjrr0mt_iw1MWkA@mail.gmail.com>
From: =?UTF-8?B?UmHDumwgR3V0acOpcnJleiBTZWdhbMOpcw==?= <rgs@itevenworks.net>
Date: Wed, 20 Sep 2017 13:10:29 -0700
Message-ID: <CAMUR=WgwhGdHrD5p2WCsRVXa0ObxAXXT4o6ZjX7vnU0b4f9O3g@mail.gmail.com>
Subject: Re: Major issue with Container Nodes/TTL nodes!!!
To: "dev@zookeeper.apache.org" <dev@zookeeper.apache.org>
Cc: Jordan Zimmerman <jordan@jordanzimmerman.com>, Flavio Junqueira <fpj@apache.org>,
	Michael Han <hanm@cloudera.com>, Patrick Hunt <phunt1@gmail.com>
Content-Type: multipart/alternative; boundary="94eb2c0b689e46b11d0559a491d0"
archived-at: Wed, 20 Sep 2017 20:10:36 -0000

--94eb2c0b689e46b11d0559a491d0
Content-Type: text/plain; charset="UTF-8"

On 20 September 2017 at 12:54, Camille Fournier <camille@apache.org> wrote:

> Ok let's take this back to either public mailing list or jira. I'd write up
> thoughts on jira and ask there+ml to look. I'll try to look tonight
>

Thanks Camille!

Also, I merged this originally so I will work with Jordan on getting this
fixed. Let me know
when you have a write up of your proposed solution and I'll take a look.
Thanks!


-rgs


> On Sep 20, 2017 3:52 PM, "Jordan Zimmerman" <jordan@jordanzimmerman.com>
> wrote:
>
> > I'd like to fix it as my company and probably many others are now using
> it
> > in production. The question is how to fix it safely and correctly. Is
> email
> > the best way to discuss this? Jira? Something else?
> >
> > I must say that there appears to be a trivial fix but I need the ZK
> > committers to think about this. In SessionTrackerImpl#
> initializeNextSession()
> > only some of the server ID bits are used. We could easily just mask the 2
> > high bits as well. But, what are the implications of this? Where is this
> > serverId byte used? What must be double checked?
> >
> > -Jordan
> >
> > On Sep 20, 2017, at 2:46 PM, Camille Fournier <camille@apache.org>
> wrote:
> >
> > Would you rather roll back the feature or put in a fix?
> >
> > On Sep 20, 2017 3:44 PM, "Jordan Zimmerman" <jordan@jordanzimmerman.com>
> > wrote:
> >
> >> Hey Folks,
> >>
> >> This is very serious. Please - let's discuss immediately. I'm not
> certain
> >> how to fix this.
> >>
> >> -JZ
> >>
> >> On Sep 20, 2017, at 2:17 PM, Jordan Zimmerman <
> jordan@jordanzimmerman.com>
> >> wrote:
> >>
> >> See: https://issues.apache.org/jira/browse/ZOOKEEPER-2901
> >>
> >> It appears that the high order byte of a session ID is reserved for the
> >> ServerID. I don't know how I could have missed this or how this got by
> code
> >> review, but Container Nodes and TTL nodes are using the 2 high bits to
> >> denote container/TTL. I'll work on a fix ASAP. But, can someone validate
> >> this?
> >>
> >> -Jordan
> >>
> >>
> >>
> >
>

--94eb2c0b689e46b11d0559a491d0--