Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 56DD4200D04 for ; Mon, 11 Sep 2017 22:27:33 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5580B1609C4; Mon, 11 Sep 2017 20:27:33 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 93B011609B7 for ; Mon, 11 Sep 2017 22:27:32 +0200 (CEST) Received: (qmail 97362 invoked by uid 500); 11 Sep 2017 20:27:31 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 97351 invoked by uid 99); 11 Sep 2017 20:27:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Sep 2017 20:27:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 120F4F57AC; Mon, 11 Sep 2017 20:27:31 +0000 (UTC) From: hanm To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve... Content-Type: text/plain Message-Id: <20170911202731.120F4F57AC@git1-us-west.apache.org> Date: Mon, 11 Sep 2017 20:27:31 +0000 (UTC) archived-at: Mon, 11 Sep 2017 20:27:33 -0000 Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/338#discussion_r138179709 --- Diff: conf/log4j.properties --- @@ -63,3 +63,20 @@ log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil log4j.appender.TRACEFILE.layout=org.apache.log4j.PatternLayout ### Notice we are including log4j's NDC here (%x) log4j.appender.TRACEFILE.layout.ConversionPattern=%d{ISO8601} [myid:%X{myid}] - %-5p [%t:%C{1}@%L][%x] - %m%n +# +# zk audit logging +# +zookeeper.auditlog.file=zookeeper_audit.log +zookeeper.auditlog.threshold=INFO +audit.logger=INFO, AUDITFILE +log4j.logger.org.apache.zookeeper.audit.ZKAuditLogger=${audit.logger} +log4j.additivity.org.apache.zookeeper.audit.ZKAuditLogger=false --- End diff -- I think something like this would be better here (see how HDFS defines audit log properties for example). log4j.additivity.org.apache.zookeeper.audit = false or log4j.additivity.org.apache.zookeeper.audit.enabled = false ---