zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfenes <...@git.apache.org>
Subject [GitHub] zookeeper pull request #355: ZOOKEEPER-2809: Unnecessary stack-trace in serv...
Date Fri, 01 Sep 2017 12:02:53 GMT
GitHub user mfenes opened a pull request:

    https://github.com/apache/zookeeper/pull/355

    ZOOKEEPER-2809: Unnecessary stack-trace in server when the client dis…

    Unnecessary stack-trace in server when the client disconnects unexpectedly.
    
    Backport from master, branch-3.5 to branch-3.4. Removes unnecessary stack traces from
the catch blocks of method doIO in NIOServerCnxn. For EndOfStreamException stack trace is
replaced with logging only the message and also contains the removal of stack traces for exceptions
CancelledKeyException and IOException as per commit 6206b495 referenced in the ticket.
    This change is necessary as there are projects which consider all stack traces as bugs.

    For CancelledKeyException and IOException developers are still able to see stack traces
at log level Debug.
    This change is in sync with master and branch-3.5.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mfenes/zookeeper ZOOKEEPER-2809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #355
    
----
commit 81cd3cc42d85371bd24e427bedab1740695be819
Author: Mark Fenes <mfenes@cloudera.com>
Date:   2017-08-31T12:11:09Z

    ZOOKEEPER-2809: Unnecessary stack-trace in server when the client disconnect unexpectedly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message