zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jordan Zimmerman (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ZOOKEEPER-2907) Logged request buffer isn't useful
Date Thu, 28 Sep 2017 20:42:00 GMT

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jordan Zimmerman updated ZOOKEEPER-2907:
----------------------------------------
    Description: 
There are two places in the server code that log request errors with a message ala "Dumping
request buffer..." followed by a hex dump of the request buffer. There are 2 major problems
with this output:

# The request type is not output
# The byte-to-hex inline code doesn't pad numbers < 16

These two combine to make the output data nearly useless.

PrepRequestProcessor#pRequest() and FinalRequestProcessor#processRequest()

  was:
There are two places in the server code that log request errors with a message ala "Dumping
request buffer..." followed by a hex dump of the request buffer. There are 2 major problems
with this output:

# The request type is not output
# The byte-to-hex inline code doesn't pad numbers < 16

These two combine to make the output data nearly useless.


> Logged request buffer isn't useful
> ----------------------------------
>
>                 Key: ZOOKEEPER-2907
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2907
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.10, 3.5.3
>            Reporter: Jordan Zimmerman
>            Priority: Minor
>
> There are two places in the server code that log request errors with a message ala "Dumping
request buffer..." followed by a hex dump of the request buffer. There are 2 major problems
with this output:
> # The request type is not output
> # The byte-to-hex inline code doesn't pad numbers < 16
> These two combine to make the output data nearly useless.
> PrepRequestProcessor#pRequest() and FinalRequestProcessor#processRequest()



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message