zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2887) define dependency versions in build.xml to be easily overridden in build.properties
Date Fri, 01 Sep 2017 18:54:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151019#comment-16151019
] 

ASF GitHub Bot commented on ZOOKEEPER-2887:
-------------------------------------------

GitHub user tamaashu opened a pull request:

    https://github.com/apache/zookeeper/pull/357

    ZOOKEEPER-2887: define dependency versions in build.xml to be easily …

    …overridden in build.properties
    
    If the dependency versions are defined in build.xml they can be easily
    overridden by re-defining them in build.properties
    This process can be useful to avoid classpath clashes among different
    Hadoop components

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tamaashu/zookeeper ZOOKEEPER-2887

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #357
    
----
commit 6cf315fdd6e7df2d091a5cd3a9753cb40d4357fe
Author: Tamas Penzes <tamaas@cloudera.com>
Date:   2017-09-01T18:50:23Z

    ZOOKEEPER-2887: define dependency versions in build.xml to be easily overridden in build.properties
    
    If the dependency versions are defined in build.xml they can be easily
    overridden by re-defining them in build.properties
    This process can be useful to avoid classpath clashes among different
    Hadoop components

----


> define dependency versions in build.xml to be easily overridden in build.properties
> -----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2887
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2887
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tamas Penzes
>            Assignee: Tamas Penzes
>
> Dependency versions are defined in ivy.xml, which is suboptimal since it is hard to override
them from a script.
> If we defined the versions in the main build.xml (just as we do with audience-annotations.version)
and use variables in ivy.xml then we could easily override the versions with creating a build.properties
file, which mechanism is already built in.
> This way the dependency versions could be replaced by sed or any simple command line
tool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message