zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Han (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2882) memory leak in zoo_amulti() function
Date Wed, 06 Sep 2017 14:13:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155407#comment-16155407
] 

Michael Han commented on ZOOKEEPER-2882:
----------------------------------------

{{Total time: 551 minutes 16 seconds}}

It's the first time I've ever seen unit tests took this long :)

The error message here indicates that some, if not all of the tests were failing. That is
not cool, but usually OK as we have some flaky tests. Were you able to identify which tests
were failing? 

Another suggestion is - since you are making change to C client, you can just run C tests
and skip java tests. Something like:
{{ant test-core-cppunit}}

> memory leak in zoo_amulti() function
> ------------------------------------
>
>                 Key: ZOOKEEPER-2882
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2882
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>            Reporter: guoxiang niu
>            Assignee: guoxiang niu
>            Priority: Minor
>
> when default branch is executed in switch(op->type) , alloced memory for oa variable
will leak, so, close_buffer_oarchive(&oa, 1); should be called before returning in default
branch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message