zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2809) Unnecessary stack-trace in server when the client disconnect unexpectedly
Date Fri, 01 Sep 2017 13:03:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150470#comment-16150470
] 

Hadoop QA commented on ZOOKEEPER-2809:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require
tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/987//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/987//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/987//console

This message is automatically generated.

> Unnecessary stack-trace in server when the client disconnect unexpectedly
> -------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2809
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2809
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.8
>            Reporter: Paul Millar
>            Assignee: Mark Fenes
>            Priority: Minor
>             Fix For: 3.5.0
>
>
> In ZK 3.4.x, if the client disconnects unexpectedly then the server logs this with a
stack-trace (see src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java:356).
> This is unfortunate as we are using an embedded ZK server in our project (in a test environment)
and we consider all stack-traces as bugs.
> I noticed that ZK 3.5 and later no longer log a stack-trace.  This change is due to commit
6206b495 (in branch-3.5), which adds ZOOKEEPER-1504 and seems to fix this issue almost as
a side-effect; a similar change in master has the same effect.
> I was wondering if the change in how EndOfStreamException is logged (i.e., logging the
message without a stack-trace) could be back-ported to 3.4 branch, so could be included in
the next 3.4 release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message