zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2630) Use interface type instead of implementation type when appropriate.
Date Tue, 12 Sep 2017 01:57:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162359#comment-16162359
] 

ASF GitHub Bot commented on ZOOKEEPER-2630:
-------------------------------------------

Github user eribeiro commented on the issue:

    https://github.com/apache/zookeeper/pull/354
  
    @hanm oh, totally my fault asking an already answered question. Excuse me. Even tough,
I see my (useless) question and your comment were roughly 9 hours ago, and I remember very
well the last comment I saw on this thread being "Committed to master: 1165794." (also about
9 hours ago). So, I suppose it was some sort of eventual consistency glitch that prevented
me from reading your comment before posting. Whatever, sorry about that.
    
    
    @tamaashu Please, let me know if you are planning to work on porting the changes in this
PR to branch-3.5 and branch-3.4. If you cannot and don't mind, I can pick up the work of porting
the changes in this PR to branch-3.5, at least. Best regards!


> Use interface type instead of implementation type when appropriate.
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2630
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2630
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Michael Han
>            Assignee: Tamas Penzes
>            Priority: Trivial
>              Labels: newbie, refactoring
>             Fix For: 3.6.0
>
>
> There are a couple of places in code base where we declare a field / variable as implementation
type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places
we do the opposite by declaring as interface type. A quick check indicates that most if not
all of these places could be updated so we have a consistent style over the code base (prefer
using interface type), which is also a good coding style to stick per best practice.
> See more info on https://github.com/apache/zookeeper/pull/102



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message