zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...
Date Mon, 11 Sep 2017 20:27:51 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/338#discussion_r138180155
  
    --- Diff: conf/log4j.properties ---
    @@ -63,3 +63,20 @@ log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
     log4j.appender.TRACEFILE.layout=org.apache.log4j.PatternLayout
     ### Notice we are including log4j's NDC here (%x)
     log4j.appender.TRACEFILE.layout.ConversionPattern=%d{ISO8601} [myid:%X{myid}] - %-5p
[%t:%C{1}@%L][%x] - %m%n
    +#
    +# zk audit logging
    +#
    +zookeeper.auditlog.file=zookeeper_audit.log
    +zookeeper.auditlog.threshold=INFO
    +audit.logger=INFO, AUDITFILE
    +log4j.logger.org.apache.zookeeper.audit.ZKAuditLogger=${audit.logger}
    +log4j.additivity.org.apache.zookeeper.audit.ZKAuditLogger=false
    +log4j.appender.AUDITFILE=org.apache.log4j.RollingFileAppender
    --- End diff --
    
    How is the rolling of the audit log file defined? Is it controlled by the `log4j.appender.AUDITFILE.Threshold`
property?
    
    Should we also add something like DailyRollingFileAppender and a date pattern property
as another alternative for rolling logs?


---

Mime
View raw message