zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #355: ZOOKEEPER-2809: Unnecessary stack-trace in serv...
Date Fri, 01 Sep 2017 21:04:11 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/355#discussion_r136665164
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
    @@ -374,14 +373,12 @@ void doIO(SelectionKey k) throws InterruptedException {
                 // expecting close to log session closure
                 close();
             } catch (EndOfStreamException e) {
    -            LOG.warn("caught end of stream exception",e); // tell user why
    -
    +            LOG.warn(e.getMessage());
    --- End diff --
    
    Do we want to log the whole stack trace if debug is enabled here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message