zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...
Date Fri, 01 Sep 2017 20:36:33 GMT
Github user afine commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java ---
    @@ -54,6 +54,7 @@
         static final ByteBuffer closeConn = ByteBuffer.allocate(0);
    +    private static String loginUser = System.getProperty("user.name", "<NA>");
    --- End diff --
    Perhaps this can be renamed? Maybe "serverUser" or something to clarify this is not the
same thing as the user "logged in" on the client. Or at least a comment.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message