Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 11FAC166FF2 for ; Tue, 22 Aug 2017 15:56:04 +0200 (CEST) Received: (qmail 87770 invoked by uid 500); 22 Aug 2017 13:56:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 87759 invoked by uid 99); 22 Aug 2017 13:56:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 13:56:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 39CFFC2FB2 for ; Tue, 22 Aug 2017 13:56:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6gcOnBkdzqco for ; Tue, 22 Aug 2017 13:56:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EE20E5FE66 for ; Tue, 22 Aug 2017 13:56:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 10780E0D57 for ; Tue, 22 Aug 2017 13:56:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6596725383 for ; Tue, 22 Aug 2017 13:56:00 +0000 (UTC) Date: Tue, 22 Aug 2017 13:56:00 +0000 (UTC) From: "Dan Benediktson (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2879) Adding observers dynamically without server id MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136823#comment-16136823 ] Dan Benediktson commented on ZOOKEEPER-2879: -------------------------------------------- [~hanm] No, local sessions are not a sufficient mitigation for the problems introduced by this proposed feature: - Local sessions can be upgraded to a global session at any time by creating an ephemeral node; basically, enabling local sessions across an ensemble does not guarantee that all sessions are local. If one of them upgrades, for instance, what happens to the other one? - Moreover, I believe this proposed feature would let you accidentally reuse a local session across two members of the same ensemble. Imagine two sessions connect to different members and get the same session ID: now, one of them disconnects and tries to reconnect, and lands on the second server (this is possible: local sessions are purely a server-side concept, so in practice clients with a local session DO try to reconnect to another server, even though it is guaranteed to fail). I expect it would succeed, at which point there are would be two connections for the same local session, one of which actually originated from another node. I don't know precisely what this would entail, but it's probably also undesirable. > Adding observers dynamically without server id > ---------------------------------------------- > > Key: ZOOKEEPER-2879 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2879 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum > Affects Versions: 3.6.0 > Reporter: Fangmin Lv > Assignee: Fangmin Lv > > Dynamic config requires observer has unique server id, which means we cannot simply add observer with dynamic server id -1. For large observer cluster, it's much more easier to add observer without unique server id if it doesn't need to be promoted to participant. Also, it will make dynamic config more efficient, we don't need to store and send the long list of observers during re-config. -- This message was sent by Atlassian JIRA (v6.4.14#64029)