Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Thu, 31 Aug 2017 03:13:00 +0000 (UTC)
From: "gaoshu (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13003762.1473400232000.166277.1504149180240@Atlassian.JIRA>
In-Reply-To: <JIRA.13003762.1473400232000@Atlassian.JIRA>
References: <JIRA.13003762.1473400232000@Atlassian.JIRA> <JIRA.13003762.1473400232560@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2572) Potential resource leak in
 FileTxnLog.truncate
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 31 Aug 2017 03:13:07 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148386#comment-16148386 ] 

gaoshu commented on ZOOKEEPER-2572:
-----------------------------------

IMO, the exception happened in FileTxnLog.truncate can be got caught in that function.   log exception, release resource and return false. Then the dead code will be work. 

> Potential resource leak in FileTxnLog.truncate
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-2572
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2572
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Michael Han
>             Fix For: 3.5.4, 3.6.0, 3.4.11
>
>
> In FileTxnLog.truncate, we have:
> {code}
> public boolean truncate(long zxid) throws IOException {
>         FileTxnIterator itr = null;
>         try {
>             itr = new FileTxnIterator(this.logDir, zxid);
>             PositionInputStream input = itr.inputStream;
>             if(input == null) {
>                 throw new IOException("No log files found to truncate! This could " +
>                         "happen if you still have snapshots from an old setup or " +
>                         "log files were deleted accidentally or dataLogDir was changed in zoo.cfg.");
>             }
>             long pos = input.getPosition();
>             // now, truncate at the current position
>             RandomAccessFile raf=new RandomAccessFile(itr.logFile,"rw");
>             raf.setLength(pos);
>             raf.close();
>             while(itr.goToNextLog()) {
>                 if (!itr.logFile.delete()) {
>                     LOG.warn("Unable to truncate {}", itr.logFile);
>                 }
>             }
>         } finally {
>             close(itr);
>         }
>         return true;
>     }
> {code}
> {{raf}} here can be potentially in a state of not closed after leaving the method, if there is an (IO) exception thrown from setLength.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)