Return-Path: <dev-return-63293-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 49BD22004A1
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 24 Aug 2017 21:16:11 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 4820016B6DA; Thu, 24 Aug 2017 19:16:11 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 918D316B6DC
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 24 Aug 2017 21:16:10 +0200 (CEST)
Received: (qmail 85894 invoked by uid 500); 24 Aug 2017 19:16:08 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 85862 invoked by uid 99); 24 Aug 2017 19:16:07 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Aug 2017 19:16:07 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D80ADDF9FE; Thu, 24 Aug 2017 19:16:06 +0000 (UTC)
From: eribeiro <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-345-zookeeper@git.apache.org>
In-Reply-To: <git-pr-345-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #345: Zookeeper 2814: ignore space after comma in con...
Content-Type: text/plain
Message-Id: <20170824191606.D80ADDF9FE@git1-us-west.apache.org>
Date: Thu, 24 Aug 2017 19:16:06 +0000 (UTC)
archived-at: Thu, 24 Aug 2017 19:16:11 -0000

Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/345#discussion_r135106003
  
    --- Diff: src/java/test/org/apache/zookeeper/test/StringUtilTest.java ---
    @@ -0,0 +1,44 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.zookeeper.test;
    +
    +
    +import org.apache.zookeeper.ZKTestCase;
    +import org.apache.zookeeper.common.StringUtils;
    +import org.junit.Test;
    +
    +import java.util.Arrays;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +public class StringUtilTest extends ZKTestCase {
    +
    +    @Test
    +    public void testStrings() {
    +
    +        String s1 = "   a  ,   b  , ";
    +        assertEquals("[a, b]", StringUtils.split(s1, ",").toString());
    --- End diff --
    
    What is wrong with using
    ```
      String s1 = "   a  ,   b  , ";
      List<String> expected = Arrays.asList("a", "b");
      assertTrue(expected.equals(StringUtils.split(s1, ",")));
    ```
    ????


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---