Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: lvfangmin <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-322-zookeeper@git.apache.org>
In-Reply-To: <git-pr-322-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #322: [ZOOKEEPER-2853] Update lastZxidSeen in FileTxn...
Content-Type: text/plain
Message-Id: <20170803044833.7FD5BDFF9F@git1-us-west.apache.org>
Date: Thu,  3 Aug 2017 04:48:33 +0000 (UTC)
archived-at: Thu, 03 Aug 2017 04:48:36 -0000

Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/322#discussion_r131052814
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -199,14 +199,16 @@ public synchronized boolean append(TxnHeader hdr, Record txn)
                     LOG.warn("Current zxid " + hdr.getZxid()
    --- End diff --
    
    @maoling my vim editor will remove the tailing space automatically, that's why there is so many changes, I think it's better to format it without tailing space.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---