zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maoling <...@git.apache.org>
Subject [GitHub] zookeeper pull request #339: ZOOKEEPER-2581:Not handled NullPointerException...
Date Tue, 22 Aug 2017 12:43:22 GMT
GitHub user maoling opened a pull request:

    https://github.com/apache/zookeeper/pull/339

    ZOOKEEPER-2581:Not handled NullPointerException while creating key manager and trustManager

    - when **zookeeper.ssl.keyStore.password**    is null,**keyStorePasswordProp** is **null**
,then **keyStorePassword.toCharArray()** is called,it will throw a NPE. we should handle this
NPE gracefully
    - I just follow an example from [createSSLContext](https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/common/X509Util.java#L87)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maoling/zookeeper ZOOKEEPER-2581

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #339
    
----
commit af05da12f86dd062bbcefc5be2b8ab79c762d99f
Author: maoling <maoling199210191@sina.com>
Date:   2017-08-22T10:47:20Z

    ZOOKEEPER-2581:Not handled NullPointerException while creating key
    manager and trustManager

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message