zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2874) Windows Debug builds don't link with `/MTd`
Date Fri, 11 Aug 2017 22:47:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124218#comment-16124218

Hadoop QA commented on ZOOKEEPER-2874:

+1 overall.  GitHub Pull Request  Build

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/940//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/940//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/940//console

This message is automatically generated.

> Windows Debug builds don't link with `/MTd`
> -------------------------------------------
>                 Key: ZOOKEEPER-2874
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2874
>             Project: ZooKeeper
>          Issue Type: Bug
>         Environment: Windows 10 using CMake
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
> While not apparent when building ZooKeeper stand-alone, further testing when linking
with Mesos revealed it was ZooKeeper that was causing the warning:
> {noformat}
> LIBCMTD.lib(initializers.obj) : warning LNK4098: defaultlib 'libcmt.lib' conflicts with
use of other libs; use /NODEFAULTLIB:library [C:\Users\andschwa\src\mesos\build\src\slave\mesos-agent.vcxproj]
> {noformat}
> As Mesos is linking with {{/MTd}} in Debug configuration (which is the most common practice).
> Once I found the source of the warning, the fix is trivial and I am posting a patch.

This message was sent by Atlassian JIRA

View raw message