zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2870) Improve the efficiency of AtomicFileOutputStream
Date Wed, 09 Aug 2017 20:22:01 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120593#comment-16120593
] 

Hadoop QA commented on ZOOKEEPER-2870:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require
tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/933//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/933//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/933//console

This message is automatically generated.

> Improve the efficiency of AtomicFileOutputStream
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-2870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2870
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.10, 3.5.3, 3.6.0
>            Reporter: Fangmin Lv
>            Assignee: Fangmin Lv
>
> The AtomicFileOutputStream extends from FilterOutputStream, where the write function
writes data to underlying stream byte by byte: https://searchcode.com/codesearch/view/17990706/,
which is very inefficient. 
> Currently, we only this this class to write the dynamic config, because it's quite small
it won't be a big problem. But in the future we may want to use this class to write the snapshot
file, which will take much longer time, tested inside, writing 600MB snapshot will take more
than 10 minutes, while using FileOutputStream directly only takes 6s.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message