zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2853) The lastZxidSeen in FileTxnLog.java is never being assigned
Date Thu, 03 Aug 2017 04:59:02 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112188#comment-16112188
] 

ASF GitHub Bot commented on ZOOKEEPER-2853:
-------------------------------------------

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/322#discussion_r131053635
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -199,14 +199,16 @@ public synchronized boolean append(TxnHeader hdr, Record txn)
                     LOG.warn("Current zxid " + hdr.getZxid()
    --- End diff --
    
    I would recommend make the early return changes here as the changes to be made is small
and they are not hard to review. When we say "do it separately" in the context of zk, it probably
implies "never" <grin>


> The lastZxidSeen in FileTxnLog.java is never being assigned
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-2853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2853
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Fangmin Lv
>            Assignee: Fangmin Lv
>            Priority: Minor
>             Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> There is log in FileTxnLog#append to track the txn with smaller zxid than the last seen,
but the lastZxidSeen is never being assigned, so that log is not printed when it's happened.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message