zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2836) QuorumCnxManager.Listener Thread Better handling of SocketTimeoutException
Date Fri, 18 Aug 2017 15:37:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133137#comment-16133137

ASF GitHub Bot commented on ZOOKEEPER-2836:

Github user skamille commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -638,13 +639,22 @@ public void run() {
                         LOG.info("My election bind port: " + addr.toString());
    +                    ss.setSoTimeout(10 * 1000); // Ten seconds
    --- End diff --
    By setting the timeout to 10s the timeout exception will fire potentially every 10s, is
that what we want below?

> QuorumCnxManager.Listener Thread Better handling of SocketTimeoutException
> --------------------------------------------------------------------------
>                 Key: ZOOKEEPER-2836
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2836
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: leaderElection, quorum
>    Affects Versions: 3.4.6
>         Environment: Machine: Linux 3.2.0-4-amd64 #1 SMP Debian 3.2.78-1 x86_64 GNU/Linux
> Java Version: jdk64/jdk1.8.0_40
> zookeeper version: 
>            Reporter: Amarjeet Singh
>            Priority: Critical
> QuorumCnxManager Listener thread blocks SocketServer on accept but we are getting SocketTimeoutException
 on our boxes after 49days 17 hours . As per current code there is a 3 times retry and after
that it says "_As I'm leaving the listener thread, I won't be able to participate in leader
election any longer: $<hostname>/$<ip>:3888__" , Once server nodes reache this
state and we restart or add a new node ,it fails to join cluster and logs 'WARN  QuorumPeer<myid=1>/0:0:0:0:0:0:0:0:2181:QuorumCnxManager@383
- Cannot open channel to 3 at election address $<hostname>/$<ip>:3888' .
>         As there is no timeout specified for ServerSocket it should never timeout but
there are some already discussed issues where people have seen this issue and added checks
for SocketTimeoutException explicitly like https://issues.apache.org/jira/browse/KARAF-3325
>         I think we need to handle SocketTimeoutException on similar lines for zookeeper
as well 

This message was sent by Atlassian JIRA

View raw message