zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string
Date Wed, 23 Aug 2017 17:45:01 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138737#comment-16138737
] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
-------------------------------------------

GitHub user nikhilbhide opened a pull request:

    https://github.com/apache/zookeeper/pull/343

    ZOOKEEPER-2814: Ignore space after comma in connection string

    Proposed changes:
    - StringUtils.java
       - New class org.apache.zookeeper.common.StringUtils to be added
       - Logic to split trim the spaces to be added in split method
    
    - ConnectStringParser
      - Instead of using String#split, use StringUtils#split 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/zookeeper master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/343.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #343
    
----
commit d2a5192d9ee2e52e50f3c943790ce4b09eaab820
Author: Rakesh Radhakrishnan <rakeshr@apache.org>
Date:   2015-05-20T07:29:50Z

    ZOOKEEPER-2156: If JAVA_HOME is not set zk startup and fetching status command execution
result misleads user (J.Andreina via rakeshr)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680471 13f79535-47bb-0310-9956-ffa450edef68

commit 111d60b6253e3e2911a6ff525f0af792e7793ce5
Author: Rakesh Radhakrishnan <rakeshr@apache.org>
Date:   2015-05-22T05:24:39Z

    ZOOKEEPER-2191: Continue supporting prior Ant versions that don't implement the threads
attribute for the JUnit task (Chris Nauroth via rakeshr)
    
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680994 13f79535-47bb-0310-9956-ffa450edef68

commit 3a7a240ef7381edf15925045e9f94408177e51cd
Author: Hongchao Deng <hdeng@apache.org>
Date:   2015-05-29T17:45:53Z

    ZOOKEEPER-2187: remove duplicated code between CreateRequest{,2}
    (Raul Gutierrez Segales via hdeng)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682521 13f79535-47bb-0310-9956-ffa450edef68

commit fe63c1c4fdbfce201e193cd8723488d9a40dc498
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-05-29T19:48:23Z

    ZOOKEEPER-2179: Typo in Watcher.java (Archana T via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682539 13f79535-47bb-0310-9956-ffa450edef68

commit 63884670328f09a3814db54cb4644d683822e4d4
Author: Hongchao Deng <hdeng@apache.org>
Date:   2015-05-29T21:46:49Z

    ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
    (Raul Gutierrez Segales via hdeng)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682558 13f79535-47bb-0310-9956-ffa450edef68

commit daf766aa74c0e2f584b1a30f33f946e4ac282e3a
Author: Hongchao Deng <hdeng@apache.org>
Date:   2015-05-30T16:39:30Z

    ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
    (Raul Gutierrez Segales via hdeng)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682623 13f79535-47bb-0310-9956-ffa450edef68

commit 891b12d004842e6ea09509765eaa2a18eca727c4
Author: Michi Mutsuzaki <michim@apache.org>
Date:   2015-05-31T09:21:07Z

    ZOOKEEPER-2198 Set default test.junit.threads to 1 (Chris Nauroth via michim)
    
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682701 13f79535-47bb-0310-9956-ffa450edef68

commit b0141aa40e44cc747d7899a2a038a3bbe19e67a7
Author: Michi Mutsuzaki <michim@apache.org>
Date:   2015-06-01T06:45:11Z

    ZOOKEEPER-2178 Native client fails compilation on Windows. (Chris Nauroth via michim)
    
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682823 13f79535-47bb-0310-9956-ffa450edef68

commit 7f52bebb90ff2d61a2428013771ce0df09890876
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-02T05:21:26Z

    ZOOKEEPER-2197 non-ascii character in FinalRequestProcessor.java
    
    To be able to use utf-8 in .java source files we now use utf-8
    encoding to build them (Michi Mutsuzaki via rgs).
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683042 13f79535-47bb-0310-9956-ffa450edef68

commit ea500b8911223fb36555b12c391adc9a20c9e28d
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-02T19:17:09Z

    ZOOKEEPER-2096: C client builds with incorrect error codes in VisualStudio 2010+
    (Vitaly Stakhovsky via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683163 13f79535-47bb-0310-9956-ffa450edef68

commit 9f89dd30187a48e39556b6305246d835b54e00ae
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-04T16:26:06Z

    ZOOKEEPER-2194: Let DataNode.getChildren() return an unmodifiable view of its
    children set (Hitoshi Mitake via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683587 13f79535-47bb-0310-9956-ffa450edef68

commit feb90fabcab3a14b075eb56f2618e6483acfebfb
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-04T17:37:26Z

    ZOOKEEPER-2204: LearnerSnapshotThrottlerTest.testHighContentionWithTimeout
    fails occasionally (Donny Nadolny via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683602 13f79535-47bb-0310-9956-ffa450edef68

commit 78b84f3ae01ca477fb94404c78bf3a098b0fcba4
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-04T17:51:16Z

    ZOOKEEPER-2163: Introduce new ZNode type: container
    (Jordan Zimmerman via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683605 13f79535-47bb-0310-9956-ffa450edef68

commit ee7ff36dcbbd3ea1dac690c7fe15891ac6fc87e2
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-05T18:38:41Z

    ZOOKEEPER-2205: Log type of unexpected quorum packet in learner handler loop
    (Hitoshi Mitake via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683833 13f79535-47bb-0310-9956-ffa450edef68

commit 5847d0d15ffc2f13d513b189d73125e98700e850
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-05T18:51:44Z

    ZOOKEEPER-2206: Add missing packet types to LearnerHandler.packetToString()
    (Hitoshi Mitake via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683842 13f79535-47bb-0310-9956-ffa450edef68

commit b90a32fa1518c4f6c46d5c7d25cda4937a4f496f
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-05T19:15:36Z

    ZOOKEEPER-2207: Enhance error logs with LearnerHandler.packetToString()
    (Hitoshi Mitake via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683848 13f79535-47bb-0310-9956-ffa450edef68

commit ec3ee9469aeff60d65de38fa91bf4e6ca9f6a28a
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-05T19:25:41Z

    ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop
    (Akihiro Suda via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683850 13f79535-47bb-0310-9956-ffa450edef68

commit bedcfed45550b59d088e556ce463e1fdcba3242b
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-05T19:28:23Z

    ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop
    (update CHANGES.txt) (Akihiro Suda via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683851 13f79535-47bb-0310-9956-ffa450edef68

commit 71dd96a232cb590e90601fde4bfafcd4eef1f82a
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-06T01:48:52Z

    ZOOKEEPER-2201: Network issues can cause cluster to hang due to near-deadlock
    (Donny Nadolny via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683878 13f79535-47bb-0310-9956-ffa450edef68

commit 9bee4674c015a71785daeb7a6da93676a3450699
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-11T18:09:19Z

    ZOOKEEPER-2213: Empty path in Set crashes server and prevents restart
    (Hongchao Deng via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1684956 13f79535-47bb-0310-9956-ffa450edef68

commit b58a0621fb0f3495d7c010308d2822f245a56a00
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-12T21:02:55Z

    ZOOKEEPER-2214: Findbugs warning: LearnerHandler.packetToString Dead
    store to local variable (Hongchao Deng via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685167 13f79535-47bb-0310-9956-ffa450edef68

commit 2d94a794d33a27567b37b772c08316277ee4e547
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-13T00:42:49Z

    ZOOKEEPER-706: Large numbers of watches can cause session re-establishment to fail
    (Chris Thunes via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685200 13f79535-47bb-0310-9956-ffa450edef68

commit 6a2f5e3e76f85e7aeba72f94397315bec96ea4f1
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-15T23:05:25Z

    ZOOKEEPER-2212: distributed race condition related to QV version
    (Akihiro Suda via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685685 13f79535-47bb-0310-9956-ffa450edef68

commit 61df2ce2aeda8df79fa3f33c07cac23b9f6b1ca3
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-18T19:23:18Z

    ZOOKEEPER-2185: Run server with -XX:+HeapDumpOnOutOfMemoryError and
    -XX:OnOutOfMemoryError='kill %p' (Chris Nauroth via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686296 13f79535-47bb-0310-9956-ffa450edef68

commit b9c65eb6be6959639eb691642d60a88960888b49
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-22T00:18:57Z

    ZOOKEEPER-2210: clock_gettime is not available in OS X
    (Michi Mutsuzaki via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1686767 13f79535-47bb-0310-9956-ffa450edef68

commit c520e1e826d88955db7637a33cd4f20c20c0bd7a
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-27T00:03:30Z

    ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously
    (Yasuhito Fukuda via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1687876 13f79535-47bb-0310-9956-ffa450edef68

commit 352022265deb93110b7370e0fc2df6809985a60a
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-28T19:09:49Z

    ZOOKEEPER-2140: NettyServerCnxn and NIOServerCnxn code should be improved
    (Arshad Mohammad via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688041 13f79535-47bb-0310-9956-ffa450edef68

commit a61b4e1b528cb4c70627e9f9295b34bb05a79303
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-06-30T18:50:11Z

    ZOOKEEPER-2221: Zookeeper JettyAdminServer server should start on configured IP
    (Surendra Singh Lilhore via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1688505 13f79535-47bb-0310-9956-ffa450edef68

commit 9a9d587861606884cca5b4a532078f925b50e40c
Author: Rakesh Radhakrishnan <rakeshr@apache.org>
Date:   2015-07-05T04:05:33Z

    ZOOKEEPER-2224: Four letter command hangs when network is slow (Arshad Mohammad via rakeshr)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689211 13f79535-47bb-0310-9956-ffa450edef68

commit 3c9c66ac68e430a435b6bd02a9ab5cde03f31e11
Author: Raúl Gutiérrez Segalés <rgs@apache.org>
Date:   2015-07-07T05:11:49Z

    ZOOKEEPER-2223: support method-level JUnit testcase
    (Akihiro Suda via rgs)
    
    git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1689571 13f79535-47bb-0310-9956-ffa450edef68

----


> Ignore space after comma in connection string
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-2814
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.3
>            Reporter: Viliam Durina
>            Assignee: Nikhil Ashok Bhide
>            Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,<space>10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at org.apache.zookeeper.client.StaticHostProvider.<init>(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space optional
or produce error on it, as this is a real pain to spot. Using the space also makes the connect
string more readable. Spaces are not allowed in domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message