zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Han <h...@cloudera.com>
Subject Re: Process for reviewing submitted patches?
Date Wed, 16 Aug 2017 17:26:45 GMT
We are using github pull request instead of the old patch approach since
last October. So the status of JIRA is irrelevant now (in particular, Patch
Available will not trigger Jenkins pre-commit workflow now.). This was
discussed on dev list when we moved to github, the thread's name is "[VOTE]
move Apache Zookeeper to git".

As for how to identify available patches for review, they should be all
here:
https://github.com/apache/zookeeper/pulls

To get notified for new incoming pull requests:
* Watch our github repo: https://github.com/apache/zookeeper
Or
* Subscribe to dev mailing list. Because we have git -> JIRA hook any new
pull request will get cross posted to JIRA which will then be forwarded to
dev mailing list.

On Wed, Aug 16, 2017 at 10:15 AM, Patrick Hunt <phunt@apache.org> wrote:

> On Wed, Aug 16, 2017 at 9:51 AM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
>
> > * Review other people's patch. If you help out, others will be more
> willing
> > to do the same for you. If someone is kind enough to review your code,
> you
> > should return the favor to for someone else.
> >
> >
> > That's fair - I should personally try to do more of this. I'll make an
> > effort here.
> >
> >
> It's not clear to me how we are identifying patches for review today. We
> used to have a very clear process -  a jira needed to be in the "patch
> available" state in order to be considered for commit.
>
> See "contribute" section here, notice that it's watered down from what it
> used to be:
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
>
> Dan's patch is not in "patch available" state, is that one of the reasons
> why it's not being moved forward?
>
> Patrick
>
>
> > -Jordan
> >
>



-- 
Cheers
Michael.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message