zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilbhide <...@git.apache.org>
Subject [GitHub] zookeeper pull request #345: Zookeeper 2814: ignore space after comma in con...
Date Thu, 31 Aug 2017 04:58:56 GMT
Github user nikhilbhide commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/345#discussion_r136246013
  
    --- Diff: src/java/main/org/apache/zookeeper/common/StringUtils.java ---
    @@ -0,0 +1,44 @@
    +/* Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.common;
    --- End diff --
    
    Hi afine: Can you please complete the review comments? Can you please approve the changes
so that patch can be created.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message