zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilbhide <...@git.apache.org>
Subject [GitHub] zookeeper pull request #345: Zookeeper 2814: ignore space after comma in con...
Date Thu, 31 Aug 2017 04:58:44 GMT
Github user nikhilbhide commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/345#discussion_r136245995
  
    --- Diff: src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
    @@ -20,8 +20,11 @@
     
     import java.net.InetSocketAddress;
     import java.util.ArrayList;
    +import java.util.List;
     
     import org.apache.zookeeper.common.PathUtils;
    +import static org.apache.zookeeper.common.StringUtils.split;
    --- End diff --
    
    eribeiro: Can you please complete the review comments? Can you please approve the changes
so that patch can be created.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message