zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...
Date Fri, 25 Aug 2017 22:16:12 GMT
Github user afine commented on a diff in the pull request:

    --- Diff: src/java/test/org/apache/zookeeper/audit/ZKAuditLoggerTest.java ---
    @@ -0,0 +1,377 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.zookeeper.audit;
    +import static org.apache.zookeeper.test.ClientBase.CONNECTION_TIMEOUT;
    +import static org.junit.Assert.assertEquals;
    +import java.io.ByteArrayOutputStream;
    +import java.io.IOException;
    +import java.io.LineNumberReader;
    +import java.io.StringReader;
    +import java.net.InetAddress;
    +import java.net.InetSocketAddress;
    +import java.util.ArrayList;
    +import java.util.List;
    +import org.apache.log4j.Layout;
    +import org.apache.log4j.Level;
    +import org.apache.log4j.Logger;
    +import org.apache.log4j.SimpleLayout;
    +import org.apache.log4j.WriterAppender;
    +import org.apache.zookeeper.CreateMode;
    +import org.apache.zookeeper.KeeperException;
    +import org.apache.zookeeper.KeeperException.Code;
    +import org.apache.zookeeper.Op;
    +import org.apache.zookeeper.PortAssignment;
    +import org.apache.zookeeper.ZKTestCase;
    +import org.apache.zookeeper.ZKUtil;
    +import org.apache.zookeeper.ZooDefs;
    +import org.apache.zookeeper.ZooKeeper;
    +import org.apache.zookeeper.data.ACL;
    +import org.apache.zookeeper.data.Stat;
    +import org.apache.zookeeper.server.Request;
    +import org.apache.zookeeper.server.ServerCnxn;
    +import org.apache.zookeeper.server.quorum.QuorumPeerTestBase.MainThread;
    +import org.apache.zookeeper.test.ClientBase;
    +import org.apache.zookeeper.test.ClientBase.CountdownWatcher;
    +import org.junit.After;
    +import org.junit.Assert;
    +import org.junit.Test;
    +public class ZKAuditLoggerTest extends ZKTestCase {
    +    private static final Logger LOG = Logger.getLogger(ZKAuditLoggerTest.class);
    +    private static int SERVER_COUNT = 3;
    +    private MainThread[] mt;
    +    private ZooKeeper zk;
    +    @Test
    +    public void testAuditLogs() throws Exception {
    --- End diff --
    I really like this integration test. I think it would be great if it was a little more
    Would it be possible to use multiple auth providers oruse multiple servers and make sure
logs are only appearing on the correct server? 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message