zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...
Date Fri, 25 Aug 2017 22:16:11 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/338#discussion_r135343934
  
    --- Diff: conf/log4j.properties ---
    @@ -63,3 +63,20 @@ log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
     log4j.appender.TRACEFILE.layout=org.apache.log4j.PatternLayout
     ### Notice we are including log4j's NDC here (%x)
     log4j.appender.TRACEFILE.layout.ConversionPattern=%d{ISO8601} [myid:%X{myid}] - %-5p
[%t:%C{1}@%L][%x] - %m%n
    +#
    +# zk audit logging
    +#
    +zookeeper.auditlog.file=zookeeper_audit.log
    +zookeeper.auditlog.threshold=INFO
    +audit.logger=INFO, RFAAUDIT
    +log4j.logger.org.apache.zookeeper.audit.ZKAuditLogger=${audit.logger}
    +log4j.additivity.org.apache.zookeeper.audit.ZKAuditLogger=false
    +log4j.appender.RFAAUDIT=org.apache.log4j.RollingFileAppender
    +log4j.appender.RFAAUDIT.File=${zookeeper.log.dir}/${zookeeper.auditlog.file}
    +log4j.appender.RFAAUDIT.layout=org.apache.log4j.PatternLayout
    +log4j.appender.RFAAUDIT.layout.ConversionPattern=%d{ISO8601} %p %c{2}: %m%n
    --- End diff --
    
    Why don't we use the same conversion pattern as the other log types?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message