zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maoling <...@git.apache.org>
Subject [GitHub] zookeeper pull request #342: ZOOKEEPER-2488: Synchronized access to shutting...
Date Thu, 24 Aug 2017 14:54:56 GMT
Github user maoling commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -1155,6 +1134,19 @@ public void run() {
    +    private void electionAndSetCurVote() {
    --- End diff --
    IMHO,If you really want to refactor the code block(**Line1137-Line1149**)  **,throws Exception**
may be better than catching exception in this function!

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message