zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bitgaoshu <...@git.apache.org>
Subject [GitHub] zookeeper pull request #334: ZOOKEEPER-2836 SocketTimeoutException
Date Mon, 14 Aug 2017 03:33:57 GMT
Github user bitgaoshu commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/334#discussion_r132868731
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -647,11 +648,11 @@ public void run() {
                             numRetries = 0;
                         }
                     } catch (IOException e) {
    -                    if (shutdown) {
    -                        break;
    -                    }
                         LOG.error("Exception while listening", e);
    -                    numRetries++;
    +                    if (!(e instanceof SocketTimeoutException)) {
    +                        numRetries++;
    +                    }
    +                }finally {
    --- End diff --
    
    1. i had removed **finally** code block in my newest code.
    2. according to jira , the **SocketTimeoutException** was likely thrown every about 49days,
maybe unsigned int -1. Or, we can follow [Karaf](https://issues.apache.org/jira/browse/KARAF-3325l)
to fix this code. but i think it was thrown too often.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message