zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #333: ZOOKEEPER-2872: Interrupted snapshot sync cause...
Date Sun, 13 Aug 2017 05:19:14 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/333#discussion_r132832594
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
    @@ -364,6 +364,7 @@ protected void syncWithLeader(long newLeaderZxid) throws Exception{
             readPacket(qp);
             LinkedList<Long> packetsCommitted = new LinkedList<Long>();
             LinkedList<PacketInFlight> packetsNotCommitted = new LinkedList<PacketInFlight>();
    +        boolean syncSnapshot = false;
    --- End diff --
    
    We can level this variable definition up so it's clustered with `snapshotNeed` boolean.
    
    Another possibility is to get ride of this variable and use existing `snapshotNeeded`
- but that will do fysnc snapshot for TRUNC sync, which the existing patch will not. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message