zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch
Date Thu, 10 Aug 2017 22:53:11 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/136#discussion_r132588619
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
    @@ -74,12 +74,16 @@
     
             public final int createTTL = 21;
     
    +        public final int addPersistentWatch = 22;
    +
             public final int auth = 100;
     
             public final int setWatches = 101;
     
             public final int sasl = 102;
     
    +        public final int setWatches2 = 103;
    --- End diff --
    
    @Randgalt im guessing you meant to put "The problem is that it makes 3.5.4 clients incompatible
with 3.5.3 servers. That might make sense for 3.6.0 but it's unreasonable for .x.N release."
here. I agree totally. This code should stay the same in the 3.5 line but there is no reason
it needs to be identical to the 3.6 line which is why i think it should be changed "here".



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message