zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maoling <...@git.apache.org>
Subject [GitHub] zookeeper pull request #308: ZOOKEEPER-2842:Optimize the finish() of Send/Re...
Date Mon, 07 Aug 2017 07:51:00 GMT
Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/308#discussion_r131591226
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -233,25 +233,25 @@ public QuorumCnxManager(QuorumPeer self) {
             listener = new Listener();
             listener.setName("QuorumPeerListener");
         }
    -
    +    
    --- End diff --
    
    I cannot help doing this although I know it will increase review work.I will keep it in
my mind next time. **"When we say "do it separately" in the context of zk, it probably implies
'never'"** Quotation from hanm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message