zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log
Date Thu, 03 Aug 2017 23:19:06 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/307#discussion_r131281803
  
    --- Diff: src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
    @@ -460,11 +465,20 @@ public void processRequest(Request request) {
                 if (request.type == OpCode.closeSession) {
                     cnxn.sendCloseSession();
                 }
    +            checkLatency(request);
             } catch (IOException e) {
                 LOG.error("FIXMSG",e);
             }
         }
     
    +    private void checkLatency(Request request) {
    +        long requestLatency = Time.currentElapsedTime() - request.createTime;
    +        if((requestWarnThresholdMs > -1 && requestLatency > requestWarnThresholdMs)
|| requestWarnThresholdMs == 0) {
    --- End diff --
    
    @karanmehta93 really *really* minor nit: 
    ```
    boolean enabledAndAboveThreshold = requestWarnThresholdMs == 0 || (requestWarnThresholdMs
> -1 && requestLatency > requestWarnThresholdMs);
    
    if (enabledAndAboveThreshold) {
    ```
    
    I moved `requestWarnThresholdMs == 0` to the beginning of the expression so that the whole
expression can be short circuited if it is equals zero. ;-)
    
    But this is a so trivial recommendation that it's up to you use it or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message