zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #308: ZOOKEEPER-2842:Optimize the finish() of Send/Re...
Date Thu, 03 Aug 2017 21:17:50 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/308#discussion_r131261856
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -233,25 +233,25 @@ public QuorumCnxManager(QuorumPeer self) {
             listener = new Listener();
             listener.setName("QuorumPeerListener");
         }
    -
    +    
    --- End diff --
    
    style changes are great but would it be possible to separate them from changes to functionality?
that way it becomes easier to understand changes that are made when going through the version
control log


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message