zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #308: ZOOKEEPER-2842:Optimize the finish() of Send/Re...
Date Thu, 03 Aug 2017 21:17:46 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/308#discussion_r131261499
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -880,19 +876,20 @@ public void run() {
              * 
              * @return boolean  Value of variable running
              */
    -        synchronized boolean finish() {
    -            if(!running){
    -                /*
    -                 * Avoids running finish() twice. 
    -                 */
    -                return running;
    -            }
    -            running = false;            
    -
    -            this.interrupt();
    -            threadCnt.decrementAndGet();
    -            return running;
    -        }
    +		boolean finish() {
    --- End diff --
    
    I understand what you are trying to do here and why this is optimized. I'm just concerned
that that any performance increase here would not be worth the decrease in readability.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message