zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #322: [ZOOKEEPER-2853] Update lastZxidSeen in FileTxn...
Date Thu, 03 Aug 2017 04:48:33 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/322#discussion_r131052928
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -199,14 +199,16 @@ public synchronized boolean append(TxnHeader hdr, Record txn)
                     LOG.warn("Current zxid " + hdr.getZxid()
    --- End diff --
    
    I prefer return early too, I didn't change it as it's not related with this diff, and
I'd like to make it with minimum change. I can update it here too if you guys prefer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message