Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Fri, 14 Jul 2017 12:40:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13078574.1497003621000.247717.1500036000109@Atlassian.JIRA>
In-Reply-To: <JIRA.13078574.1497003621000@Atlassian.JIRA>
References: <JIRA.13078574.1497003621000@Atlassian.JIRA> <JIRA.13078574.1497003621650@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2804) Node creation fails with NPE if
 ACLs are null
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 14 Jul 2017 12:40:06 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087254#comment-16087254 ] 

ASF GitHub Bot commented on ZOOKEEPER-2804:
-------------------------------------------

Github user jainbhupendra24 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/279#discussion_r127447190
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -1436,7 +1436,7 @@ public String create(final String path, byte data[], List<ACL> acl,
             request.setData(data);
             request.setFlags(createMode.toFlag());
             request.setPath(serverPath);
    -        if (acl != null && acl.size() == 0) {
    +        if (acl == null || acl.isEmpty() || acl.contains(null)) {
    --- End diff --
    
    Throwing IllegalArgumentException is the correct way but it may break the existing behavior. Consider the case where application code is like 
    
               zk.create(callBackHandler)` // call to create api and callback handler is passed
               doSomething();
               - - - -  // some more stuff
    
    At present, if client pass null ACL parameter, the error will be handled by callBackHandler and in application code doSomething() method will execute. 
    
    But if we throw IllegalArgumentException , then doSomething() method will not execute. So it will change the existing behavior of application code. 
    
    Please suggest if we really need to handle this case. 


> Node creation fails with NPE if ACLs are null
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-2804
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2804
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Bhupendra Kumar Jain
>
> If null ACLs are passed then zk node creation or set ACL fails with NPE
> {code}
> java.lang.NullPointerException
> 	at org.apache.zookeeper.server.PrepRequestProcessor.removeDuplicates(PrepRequestProcessor.java:1301)
> 	at org.apache.zookeeper.server.PrepRequestProcessor.fixupACL(PrepRequestProcessor.java:1341)
> 	at org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:519)
> 	at org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:1126)
> 	at org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:178)
> {code}
> Expected to handle null in server and return proper error code to client


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)